leezng commented on code in PR #9438:
URL: https://github.com/apache/inlong/pull/9438#discussion_r1418581803


##########
inlong-dashboard/src/ui/components/Charts/index.tsx:
##########
@@ -81,7 +81,7 @@ const Charts: React.FC<Props> = ({
       }
     };
     // eslint-disable-next-line
-  }, []);
+  }, [option]);

Review Comment:
   This is used for initialization. Do not monitor option changes, as 
performance problems may occur easily.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to