luchunliang commented on code in PR #9340: URL: https://github.com/apache/inlong/pull/9340#discussion_r1406996502
########## inlong-manager/manager-dao/src/main/resources/mappers/OperationLogEntityMapper.xml: ########## @@ -48,25 +51,52 @@ from operation_log where id = #{id,jdbcType=INTEGER} </select> + <select id="selectByCondition" resultMap="BaseResultMap" + parameterType="org.apache.inlong.manager.pojo.operationLog.OperationLogRequest"> + select + <include refid="Base_Column_List"/> + from operation_log + <where> + <if test="request.inlongGroupId != null and request.inlongGroupId != ''"> + and inlong_group_id = #{request.inlongGroupId, jdbcType=VARCHAR} + </if> + <if test="request.inlongStreamId != null and request.inlongStreamId != ''"> + and inlong_stream_id = #{request.inlongStreamId, jdbcType=VARCHAR} + </if> + <if test="request.operationType != null and request.operationType != ''"> + and operation_type = #{request.operationType, jdbcType=VARCHAR} + </if> + <if test="request.operationTarget != null and request.operationTarget != ''"> + and operation_target = #{request.operationTarget, jdbcType=VARCHAR} + </if> + <if test="request.startDate != null and request.startDate != '' and request.endDate != null and request.endDate != ''"> + and request_time >= #{request.startDate, jdbcType=VARCHAR} Review Comment: RequestTime type is timestamp. Please confirm that there will be no performance issues here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org