hnrainll commented on code in PR #9331:
URL: https://github.com/apache/inlong/pull/9331#discussion_r1405916183


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/node/starrocks/StarRocksDataNodeOperator.java:
##########
@@ -88,7 +89,7 @@ protected void setTargetEntity(DataNodeRequest request, 
DataNodeEntity targetEnt
 
     @Override
     public Boolean testConnection(DataNodeRequest request) {
-        String jdbcUrl = request.getUrl();
+        String jdbcUrl = MySQLDataNodeDTO.convertToJdbcurl(request.getUrl());

Review Comment:
   StarRocks jdbc url rules are the same as mysql, rewriting a copy of the same 
would make the code duplicate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to