EMsnap commented on code in PR #8246:
URL: https://github.com/apache/inlong/pull/8246#discussion_r1231932723
##########
inlong-sort/sort-formats/format-inlongmsg-base/src/main/java/org/apache/inlong/sort/formats/inlongmsg/InLongMsgValidator.java:
##########
@@ -21,17 +21,20 @@
import org.apache.inlong.sort.formats.base.TableFormatUtils;
import org.apache.flink.table.descriptors.DescriptorProperties;
-import org.apache.flink.table.descriptors.FormatDescriptorValidator;
+import org.apache.flink.table.descriptors.DescriptorValidator;
+
+import static
org.apache.inlong.sort.formats.base.TableFormatConstants.FORMAT_PROPERTY_VERSION;
+import static
org.apache.inlong.sort.formats.base.TableFormatConstants.FORMAT_TYPE;
/**
* Validator for mixed inlongmsg formats.
*/
-public class InLongMsgValidator extends FormatDescriptorValidator {
+public class InLongMsgValidator implements DescriptorValidator {
@Override
public void validate(DescriptorProperties properties) {
- super.validate(properties);
-
+ properties.validateString(FORMAT_TYPE, false, 1);
Review Comment:
InLongMsgMixedValidator have duplicate code with InlongMsgValidator could
you please extract these code ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
