[GitHub] [inlong] EMsnap commented on a diff in pull request #8095: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

[via GitHub]

EMsnap commented on code in PR #8095:
URL: https://github.com/apache/inlong/pull/8095#discussion_r1206464428


##########
inlong-sort/sort-flink/base/src/main/java/org/apache/inlong/sort/base/sink/TableChange.java:
##########
@@ -177,9 +177,80 @@ public String toString() {
 
     final class DeleteColumn implements ColumnChange {
 
+        private final String[] fieldsNames;

Review Comment:
   fieldNames  would be better ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org