healchow commented on code in PR #8074: URL: https://github.com/apache/inlong/pull/8074#discussion_r1201926520
########## inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/source2/InLongMessageHandler.java: ########## @@ -44,30 +62,6 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import java.nio.charset.StandardCharsets; Review Comment: It seems that your code style in your local IDE was changed. Please refer to this: https://github.com/apache/inlong/discussions/3082 and reformat the import order, thanks. ########## inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/source2/SimpleUdpSource.java: ########## @@ -17,15 +17,15 @@ package org.apache.inlong.dataproxy.source2; +import java.net.InetSocketAddress; Review Comment: ditto. ########## inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/source2/httpMsg/InLongHttpMsgHandler.java: ########## @@ -0,0 +1,384 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.dataproxy.source2.httpMsg; + +import static io.netty.handler.codec.http.HttpUtil.is100ContinueExpected; + +import java.io.UnsupportedEncodingException; Review Comment: ditto. ########## inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/source2/v0msg/CodecBinMsg.java: ########## @@ -17,26 +17,6 @@ package org.apache.inlong.dataproxy.source2.v0msg; -import org.apache.commons.lang3.StringUtils; Review Comment: ditto. ########## inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/source2/v0msg/CodecTextMsg.java: ########## @@ -17,6 +17,15 @@ package org.apache.inlong.dataproxy.source2.v0msg; +import static org.apache.inlong.dataproxy.source2.v0msg.MsgFieldConsts.TXT_MSG_BODYLEN_OFFSET; Review Comment: ditto. ########## inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/source2/SimpleTcpSource.java: ########## @@ -28,13 +30,11 @@ import org.apache.inlong.dataproxy.config.ConfigManager; import org.apache.inlong.dataproxy.config.holder.ConfigUpdateCallback; import org.apache.inlong.dataproxy.utils.AddressUtils; +import org.apache.inlong.dataproxy.utils.ConfStringUtils; import org.apache.inlong.dataproxy.utils.EventLoopUtil; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import java.net.InetSocketAddress; Review Comment: ditto. ########## inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/source2/v0msg/AbsV0MsgCodec.java: ########## @@ -30,12 +34,6 @@ import org.apache.inlong.dataproxy.utils.DateTimeUtils; import org.apache.inlong.dataproxy.utils.InLongMsgVer; -import java.nio.charset.StandardCharsets; Review Comment: ditto. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
