[GitHub] [inlong] chestnut-c commented on a diff in pull request #8067: [INLONG-8066][Manager] Add sort extended properties when getting the status info of the InlongGroup

[via GitHub]

chestnut-c commented on code in PR #8067:
URL: https://github.com/apache/inlong/pull/8067#discussion_r1200461441


##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/impl/InlongClientImpl.java:
##########
@@ -163,12 +166,19 @@ public Map<String, InlongGroupStatusInfo> 
listGroupStatus(List<String> groupIds,
         List<SortStatusInfo> sortStatusInfos = 
groupClient.listSortStatus(statusRequest);
 
         if (CollectionUtils.isNotEmpty(sortStatusInfos)) {
-            Map<String, SortStatus> sortStatusMap = sortStatusInfos.stream()
-                    
.collect(Collectors.toMap(SortStatusInfo::getInlongGroupId, 
SortStatusInfo::getSortStatus));
-            groupStatusMap.forEach((groupId, groupStatusInfo) -> 
groupStatusInfo
-                    .setSortStatus(sortStatusMap.getOrDefault(groupId, 
SortStatus.NOT_EXISTS)));
+            Map<String, SortStatusInfo> sortStatusInfoMap = 
sortStatusInfos.stream()
+                    
.collect(Collectors.toMap(SortStatusInfo::getInlongGroupId, 
Function.identity()));
+            groupStatusMap.forEach((groupId, groupStatusInfo) -> {
+                groupStatusInfo.setSortStatus(SortStatus.NOT_EXISTS);

Review Comment:
   > Why not use `sortStatusMap.getOrDefault(groupId, SortStatus.NOT_EXISTS)`?
   
   Because other properties of SortStatusInfo are used，the default is also the 
status SortStatus.NOT_EXISTS



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org