Yizhou-Yang commented on code in PR #7924: URL: https://github.com/apache/inlong/pull/7924#discussion_r1188185705
########## inlong-sort/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/partitioner/PrimaryKeyPartitioner.java: ########## Review Comment: I adjusted the implementation to make it schema-reliant, so that it directly extracts from rowdata instead of the serialized key now. please refresh the code to see the new implementation.. I think it is pretty distinct from raw hash partitioner now, and might take some effort to merge. The two scenerios are pretty different, when trying merge the two scenerios together ( like how i tried in Doris connector), the resulting code has proven to be.. rather hard to debug and modify, since all changes need to be compatible with both scenerios. I think that segregating the two cases strictly within connectors might lead to fewer bugs, especially in the production environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
