dockerzhang commented on code in PR #7935:
URL: https://github.com/apache/inlong/pull/7935#discussion_r1178728624
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/kafka/KafkaSourceOperator.java:
##########
@@ -131,8 +127,13 @@ public Map<String, List<StreamSource>>
getSourcesMap(InlongGroupInfo groupInfo,
if (!Objects.equals(streamId, sourceInfo.getInlongStreamId()))
{
continue;
}
- if (StringUtils.isEmpty(kafkaSource.getSerializationType()) &&
StringUtils.isNotEmpty(
- sourceInfo.getSerializationType())) {
+
+ if
(sourceInfo.getSourceType().equalsIgnoreCase(SourceType.FILE)) {
Review Comment:
Here should including `AUTO_PUSH`?
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/tubemq/TubeMQSourceOperator.java:
##########
@@ -110,17 +110,21 @@ public Map<String, List<StreamSource>>
getSourcesMap(InlongGroupInfo groupInfo,
tubeMQSource.setTopic(streamInfo.getMqResource());
tubeMQSource.setGroupId(streamId);
tubeMQSource.setMasterRpc(masterRpc);
- if (StringUtils.isNotBlank(streamInfo.getDataType())) {
- String serializationType =
DataTypeEnum.forType(streamInfo.getDataType()).getType();
- tubeMQSource.setSerializationType(serializationType);
- }
tubeMQSource.setIgnoreParseError(streamInfo.getIgnoreParseError());
for (StreamSource sourceInfo : streamSources) {
if (!Objects.equals(streamId, sourceInfo.getInlongStreamId()))
{
continue;
}
-
tubeMQSource.setSerializationType(sourceInfo.getSerializationType());
+
+ if
(sourceInfo.getSourceType().equalsIgnoreCase(SourceType.FILE)) {
Review Comment:
ditto
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/pulsar/PulsarSourceOperator.java:
##########
@@ -149,10 +145,16 @@ public Map<String, List<StreamSource>>
getSourcesMap(InlongGroupInfo groupInfo,
if (!Objects.equal(streamId, sourceInfo.getInlongStreamId())) {
continue;
}
- if (StringUtils.isEmpty(pulsarSource.getSerializationType())
- &&
StringUtils.isNotEmpty(sourceInfo.getSerializationType())) {
+
+ if
(sourceInfo.getSourceType().equalsIgnoreCase(SourceType.FILE)) {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
