chestnut-c commented on code in PR #7536:
URL: https://github.com/apache/inlong/pull/7536#discussion_r1127379871
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/pulsar/PulsarSourceOperator.java:
##########
@@ -131,8 +131,10 @@ public Map<String, List<StreamSource>>
getSourcesMap(InlongGroupInfo groupInfo,
pulsarSource.setAdminUrl(adminUrl);
pulsarSource.setServiceUrl(serviceUrl);
pulsarSource.setInlongComponent(true);
- String serializationType =
DataTypeEnum.forType(streamInfo.getDataType()).getType();
- pulsarSource.setSerializationType(serializationType);
+ if (StringUtils.isNotBlank(streamInfo.getDataType())) {
Review Comment:
>
We only tested for PulsarSource, and also took the serializationType of
StreamSource, so InlongStreamInfo is not a necessary DataType @fuweng11 you
can that context. PulsarSource takes values from two places, which leads to
the need for fault tolerance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
