[GitHub] [inlong] healchow commented on a diff in pull request #7422: [INLONG-7421][Manager] Add encoding check to the MySQL JDBC URL in MySQLDataNode

[via GitHub]

healchow commented on code in PR #7422:
URL: https://github.com/apache/inlong/pull/7422#discussion_r1116520793


##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sink/mysql/MySQLSinkDTO.java:
##########
@@ -218,7 +218,7 @@ public static String setDbNameToUrl(String jdbcUrl, String 
databaseName) {
      * @return str without sensitive param
      */
     @VisibleForTesting

Review Comment:
   This method was called by non-testing classes, so please remove this 
annotation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org