healchow commented on code in PR #7253:
URL: https://github.com/apache/inlong/pull/7253#discussion_r1098230841
##########
inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/internal/JdbcMultiBatchingOutputFormat.java:
##########
@@ -303,6 +321,42 @@ private JdbcExec getOrCreateStatementExecutor(
return jdbcExec;
}
+ private JdbcExec enhanceExecutor(JdbcExec exec) throws
NoSuchFieldException, IllegalAccessException {
+ if (dirtySinkHelper.getDirtySink() == null) {
+ return null;
+ }
+ // enhance the actual executor to tablemetricstatementexecutor
+ Field f1;
Review Comment:
Please use more clear names for variable, please.
##########
inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/internal/JdbcMultiBatchingOutputFormat.java:
##########
@@ -303,6 +321,42 @@ private JdbcExec getOrCreateStatementExecutor(
return jdbcExec;
}
+ private JdbcExec enhanceExecutor(JdbcExec exec) throws
NoSuchFieldException, IllegalAccessException {
+ if (dirtySinkHelper.getDirtySink() == null) {
+ return null;
+ }
+ // enhance the actual executor to tablemetricstatementexecutor
+ Field f1;
Review Comment:
Please use more clear names for variable, thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
