healchow commented on code in PR #7316:
URL: https://github.com/apache/inlong/pull/7316#discussion_r1095404473
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/PulsarClusterOperator.java:
##########
@@ -87,17 +95,29 @@ protected void setTargetEntity(ClusterRequest request,
InlongClusterEntity targe
}
}
- @Override
Review Comment:
Why remove it?
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/PulsarClusterOperator.java:
##########
@@ -44,6 +50,8 @@ public class PulsarClusterOperator extends
AbstractClusterOperator {
private static final Logger LOGGER =
LoggerFactory.getLogger(PulsarClusterOperator.class);
+ private static final String SERVER_URL_PREFIX = "pulsar://";
Review Comment:
It should be `service URL`.
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/PulsarClusterOperator.java:
##########
@@ -87,17 +95,29 @@ protected void setTargetEntity(ClusterRequest request,
InlongClusterEntity targe
}
}
- @Override
public Boolean testConnection(ClusterRequest request) {
PulsarClusterRequest pulsarRequest = (PulsarClusterRequest) request;
PulsarClusterInfo pulsarInfo = new PulsarClusterInfo();
CommonBeanUtils.copyProperties(pulsarRequest, pulsarInfo);
try (PulsarAdmin ignored = PulsarUtils.getPulsarAdmin(pulsarInfo)) {
- LOGGER.debug("pulsar connection not null - connection success for
adminUrl={}", pulsarInfo.getAdminUrl());
+ ignored.tenants().getTenants();
+ String serviceUrl = pulsarInfo.getUrl();
+ Preconditions.expectNotNull(serviceUrl, "ServerUrl is empty");
Review Comment:
Please change all `serverUrl` to `serviceUrl` for Apache Pulsar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
