Yizhou-Yang commented on code in PR #7148:
URL: https://github.com/apache/inlong/pull/7148#discussion_r1092682121
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/dirty/sink/s3/S3DirtySink.java:
##########
@@ -130,8 +131,16 @@ public synchronized void invoke(DirtyData<T> dirtyData)
throws Exception {
}
private boolean valid() {
- return (s3Options.getBatchSize() > 0 && size >=
s3Options.getBatchSize())
- || batchBytes >= s3Options.getMaxBatchBytes();
+ // stash dirty data for at least a minute to avoid flushing too fast
Review Comment:
OK, then don't merge this part for now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
