gosonzhang commented on code in PR #7171:
URL: https://github.com/apache/inlong/pull/7171#discussion_r1063365788
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/listener/consume/apply/ApproveConsumeProcessListener.java:
##########
@@ -130,17 +130,17 @@ private void createPulsarSubscription(InlongConsumeEntity
entity) {
ClusterInfo clusterInfo = clusterService.getOne(clusterTag, null,
ClusterType.PULSAR);
PulsarClusterInfo pulsarCluster = (PulsarClusterInfo) clusterInfo;
try (PulsarAdmin pulsarAdmin =
PulsarUtils.getPulsarAdmin(pulsarCluster)) {
- PulsarTopicInfo topicMessage = new PulsarTopicInfo();
- String tenant = pulsarCluster.getTenant();
+ InlongPulsarDTO pulsarDTO =
InlongPulsarDTO.getFromJson(groupEntity.getExtParams());
+ String tenant = pulsarDTO.getTenant();
if (StringUtils.isEmpty(tenant)) {
Review Comment:
isEmpty -- > isBlank
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/consume/ConsumePulsarOperator.java:
##########
@@ -111,12 +112,25 @@ public InlongConsumeInfo
getFromEntity(InlongConsumeEntity entity) {
}
String groupId = entity.getInlongGroupId();
InlongGroupInfo groupInfo = groupService.get(groupId);
+ if (!(groupInfo instanceof InlongPulsarInfo)) {
Review Comment:
Why not use mqType to convert directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
