[GitHub] [inlong] luchunliang commented on a diff in pull request #7167: [INLONG-7166][DataProxy] Fix audit data reporting

[GitBox]

luchunliang commented on code in PR #7167:
URL: https://github.com/apache/inlong/pull/7167#discussion_r1062309646


##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/mq/kafka/KafkaHandler.java:
##########
@@ -238,6 +243,7 @@ public void onCompletion(RecordMetadata arg0, Exception ex) 
{
                     sinkContext.addSendResultMetric(event, topic, true, 
sendTime);
                     sinkContext.getDispatchQueue().release(event.getSize());
                     event.ack();
+                    AuditUtils.add(AuditUtils.AUDIT_ID_DATAPROXY_SEND_SUCCESS, 
event.getSimpleProfile());

Review Comment:
   Repeat audit report.
   
https://github.com/apache/inlong/blob/master/inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/mq/MessageQueueZoneSinkContext.java
   
![image](https://user-images.githubusercontent.com/8925507/210755587-a71b9dae-e02a-47df-81c9-682dcab32df0.png)
   



##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/mq/kafka/KafkaHandler.java:
##########
@@ -193,6 +195,9 @@ public void onCompletion(RecordMetadata arg0, Exception ex) 
{
                     sinkContext.addSendResultMetric(event, topic, true, 
sendTime);
                     sinkContext.getDispatchQueue().release(event.getSize());
                     event.ack();
+                    for (ProxyEvent auditEvent : event.getEvents()) {
+                        
AuditUtils.add(AuditUtils.AUDIT_ID_DATAPROXY_SEND_SUCCESS, auditEvent);

Review Comment:
   Repeat audit report.
   
https://github.com/apache/inlong/blob/master/inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/mq/MessageQueueZoneSinkContext.java
   
![image](https://user-images.githubusercontent.com/8925507/210755587-a71b9dae-e02a-47df-81c9-682dcab32df0.png)
   



##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/mq/kafka/KafkaHandler.java:
##########
@@ -280,6 +286,9 @@ public void onCompletion(RecordMetadata arg0, Exception ex) 
{
                     sinkContext.addSendResultMetric(event, topic, true, 
sendTime);
                     sinkContext.getDispatchQueue().release(event.getSize());
                     event.ack();
+                    for (ProxyEvent auditEvent : event.getEvents()) {
+                        
AuditUtils.add(AuditUtils.AUDIT_ID_DATAPROXY_SEND_SUCCESS, auditEvent);
+                    }

Review Comment:
   Repeat audit report.
   
https://github.com/apache/inlong/blob/master/inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/mq/MessageQueueZoneSinkContext.java
   
![image](https://user-images.githubusercontent.com/8925507/210755587-a71b9dae-e02a-47df-81c9-682dcab32df0.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org