fuweng11 commented on code in PR #7134:
URL: https://github.com/apache/inlong/pull/7134#discussion_r1062136995
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/source/SourceRequest.java:
##########
@@ -72,8 +72,8 @@ public class SourceRequest {
@ApiModelProperty("Inlong cluster name")
private String inlongClusterName;
- @ApiModelProperty("Inlong cluster node tag")
- private String inlongClusterNodeTag;
+ @ApiModelProperty("Inlong cluster node label")
Review Comment:
Add explanation above. like @ApiModelProperty(value = "MQ resource", notes =
"in inlong group, TubeMQ corresponds to Topic, Pulsar corresponds to
Namespace").
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/cluster/ClusterNodeBindLabelRequest.java:
##########
@@ -29,11 +29,11 @@
*/
@Data
@ApiModel("Cluster node bind and unbind tag request")
-public class ClusterNodeBindTagRequest {
+public class ClusterNodeBindLabelRequest {
@NotBlank(message = "Cluster nodeTag cannot be blank")
@ApiModelProperty(value = "Cluster node tag")
Review Comment:
Add explanation above. like `@ApiModelProperty(value = "MQ resource", notes
= "in inlong group, TubeMQ corresponds to Topic, Pulsar corresponds to
Namespace")`
##########
inlong-common/src/main/java/org/apache/inlong/common/heartbeat/HeartbeatMsg.java:
##########
@@ -78,7 +78,7 @@ public class HeartbeatMsg {
/**
* Tag of node, separated by commas(,)
Review Comment:
Uniform annotation and method name.
##########
inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/StreamSourceLabelNodeRelationEntity.java:
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.entity;
+
+import lombok.Data;
+
+import java.io.Serializable;
+
+/**
+ * Inlong label node relation entity.
Review Comment:
Unified annotation and class name.
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/InlongClusterService.java:
##########
@@ -393,7 +393,7 @@ List<ClusterNodeResponse> listNodeByGroupId(
* @param operator current operator
Review Comment:
Uniform annotation and method name.
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/inner/client/InlongClusterClient.java:
##########
@@ -304,7 +304,7 @@ public Boolean deleteNode(Integer id) {
* @param request cluster info to be modified
Review Comment:
Uniform annotation and method name.
##########
inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/StreamSourceLabelEntity.java:
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.entity;
+
+import lombok.Data;
+
+import java.io.Serializable;
+import java.util.Date;
+
+/**
+ * Inlong label entity.
Review Comment:
Unified annotation and class name.
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/service/InlongClusterApi.java:
##########
@@ -101,5 +101,5 @@ Call<Response<List<ClusterNodeResponse>>>
listNodeByGroupId(@Query("inlongGroupI
Call<Response<Boolean>> deleteNode(@Path("id") Integer id);
@POST("cluster/node/bindTag")
Review Comment:
Uniform url and method name.
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/cluster/ClusterNodeBindLabelRequest.java:
##########
@@ -29,11 +29,11 @@
*/
@Data
@ApiModel("Cluster node bind and unbind tag request")
Review Comment:
Unified annotation and method name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
