leezng commented on code in PR #7145:
URL: https://github.com/apache/inlong/pull/7145#discussion_r1061391010
##########
inlong-dashboard/src/pages/Clusters/CreateModal.tsx:
##########
@@ -101,7 +121,17 @@ const Comp: React.FC<Props> = ({ id, defaultType,
...modalProps }) => {
<Modal
{...modalProps}
title={id ? i18n.t('pages.Clusters.Edit') :
i18n.t('pages.Clusters.Create')}
- onOk={onOk}
+ footer={[
+ <Button
onClick={modalProps.onCancel}>{i18n.t('basic.Cancel')}</Button>,
+ <Button type="primary" onClick={onOk}>
+ {i18n.t('basic.Save')}
+ </Button>,
+ (type === 'PULSAR' || type === 'KAFKA' || type === 'TUBEMQ') && (
Review Comment:
I don't think these types should be limited to testing, otherwise you need
to consider this when expanding the plug-in in the future, including plug-ins
for privatization deployment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
