fuweng11 commented on code in PR #7134: URL: https://github.com/apache/inlong/pull/7134#discussion_r1060433258
########## inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/InlongLabelEntity.java: ########## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.dao.entity; + +import java.io.Serializable; +import java.util.Date; + +public class InlongLabelEntity implements Serializable { Review Comment: Suggest to use `@Data`, `@EqualsAndHashCode(callSuper = true)`, etc ########## inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/InlongLabelNodeRelationEntity.java: ########## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.dao.entity; + +import java.io.Serializable; + +public class InlongLabelNodeRelationEntity implements Serializable { Review Comment: Suggest to use `@Data`, `@EqualsAndHashCode(callSuper = true)`, etc ########## inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/InlongLabelEntityMapper.java: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.dao.mapper; + +import org.apache.inlong.manager.dao.entity.InlongLabelEntity; + Review Comment: Add`@Repository`. ########## inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/InlongLabelNodeRelationEntityMapper.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.dao.mapper; + +import org.apache.ibatis.annotations.Param; +import org.apache.inlong.manager.dao.entity.InlongLabelNodeRelationEntity; + +import java.util.List; + Review Comment: Add`@Repository.` ########## inlong-manager/manager-dao/src/main/resources/mappers/InlongLabelEntityMapper.xml: ########## @@ -0,0 +1,71 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +<!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN" "http://mybatis.org/dtd/mybatis-3-mapper.dtd";> +<mapper namespace="org.apache.inlong.manager.dao.mapper.InlongLabelEntityMapper"> + <resultMap id="BaseResultMap" type="org.apache.inlong.manager.dao.entity.InlongLabelEntity"> + <id column="id" jdbcType="INTEGER" property="id" /> + <result column="label_name" jdbcType="VARCHAR" property="labelName" /> + <result column="description" jdbcType="VARCHAR" property="description" /> + <result column="in_charges" jdbcType="VARCHAR" property="inCharges" /> + <result column="is_deleted" jdbcType="INTEGER" property="isDeleted" /> + <result column="creator" jdbcType="VARCHAR" property="creator" /> + <result column="modifier" jdbcType="VARCHAR" property="modifier" /> + <result column="create_time" jdbcType="TIMESTAMP" property="createTime" /> + <result column="modify_time" jdbcType="TIMESTAMP" property="modifyTime" /> + <result column="version" jdbcType="INTEGER" property="version" /> + </resultMap> + <resultMap extends="BaseResultMap" id="ResultMapWithBLOBs" type="org.apache.inlong.manager.dao.entity.InlongLabelEntity"> + <result column="ext_params" jdbcType="LONGVARCHAR" property="extParams" /> + </resultMap> + <sql id="Base_Column_List"> + id, label_name, description, in_charges, is_deleted, creator, modifier, create_time, + modify_time, version + </sql> + <sql id="Blob_Column_List"> Review Comment: Why `ext_params` are not put together with other parameters？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
