kuansix commented on code in PR #7079:
URL: https://github.com/apache/inlong/pull/7079#discussion_r1058784618
##########
inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/internal/JdbcMultiBatchingOutputFormat.java:
##########
@@ -399,14 +420,44 @@ protected GenericRowData generateRecord(RowType rowType,
Map<String, String> fie
record.setField(i, Double.valueOf(fieldValue));
break;
case TIME_WITHOUT_TIME_ZONE:
- case TIMESTAMP_WITHOUT_TIME_ZONE:
+ // case TIMESTAMP_WITHOUT_TIME_ZONE:
case INTERVAL_DAY_TIME:
TimestampData timestampData =
TimestampData.fromEpochMillis(Long.valueOf(fieldValue));
record.setField(i, timestampData);
break;
case BINARY:
record.setField(i,
Arrays.toString(fieldValue.getBytes(StandardCharsets.UTF_8)));
break;
+
Review Comment:
Can L431-L460 also apply to CK、GP、Oracle、PG、SqlServer、TDSQL ？
##########
inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/internal/JdbcMultiBatchingOutputFormat.java:
##########
@@ -399,14 +420,44 @@ protected GenericRowData generateRecord(RowType rowType,
Map<String, String> fie
record.setField(i, Double.valueOf(fieldValue));
break;
case TIME_WITHOUT_TIME_ZONE:
- case TIMESTAMP_WITHOUT_TIME_ZONE:
+ // case TIMESTAMP_WITHOUT_TIME_ZONE:
Review Comment:
remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
