gong commented on code in PR #7085:
URL: https://github.com/apache/inlong/pull/7085#discussion_r1058183397


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/metric/sub/SinkTableMetricData.java:
##########
@@ -180,7 +180,7 @@ public void outputMetricsWithEstimate(String database, 
String schema, String tab
      * @param rowCount the row count of records
      * @param rowSize the row size of records
      */
-    public void outputMetricsWithEstimate(String database, String schema, 
String table, boolean isSnapshotRecord,
+    public void outputMetrics(String database, String schema, String table, 
boolean isSnapshotRecord,

Review Comment:
   isSnapshotRecord is useless. It is only used for sourcemetric



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to