healchow commented on code in PR #7050: URL: https://github.com/apache/inlong/pull/7050#discussion_r1057155189
########## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/sink/hudi/HudiTypeConverter.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.service.resource.sink.hudi; + +import org.apache.inlong.manager.pojo.sink.hudi.HudiColumnInfo; +import org.apache.inlong.manager.pojo.sink.hudi.HudiType; + +import java.util.Optional; + +/** + * Converter between Java type and Hive type that reflects the behavior before This converter reflects the old behavior + * that includes: + * <ul> + * <li>Use old java.sql.* time classes for time data types. + * <li>Only support millisecond precision for timestamps or day-time intervals. + * <li>Let variable precision and scale for decimal types pass through the planner. + * </ul> + * {@see org.apache.flink.table.types.utils.TypeInfoDataTypeConverter} + */ +public class HudiTypeConverter { + + /** + * Converter field type of column to Hive field type. + */ + public static String convert(HudiColumnInfo column) { + return Optional.ofNullable(column) + .map(HudiColumnInfo::getType) + .map(HudiType::forType) Review Comment: Using many maps will lead to low efficiency. It is recommended to compress the following two maps into one: ``` .map(HudiColumnInfo::getType) .map(HudiType::forType) ``` Because the 'HudiType:: forType' method will throw an exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
