yunqingmoswu commented on code in PR #6979:
URL: https://github.com/apache/inlong/pull/6979#discussion_r1053061727
##########
inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/table/AbstractJdbcDialect.java:
##########
@@ -98,4 +99,12 @@ public void validate(TableSchema schema) throws
ValidationException {
* @return a list of logical type roots.
*/
public abstract List<LogicalTypeRoot> unsupportedTypes();
+
+ /**
+ * get getPkNames from query db.tb
+ *
+ * @return a list of PkNames.
+ */
+ public abstract List<String> getPkNamesFromDb(String tableIdentifier,
Review Comment:
maybe it is better to remove abstract, subclass can override it if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
