healchow commented on code in PR #6959: URL: https://github.com/apache/inlong/pull/6959#discussion_r1052908986
########## inlong-sdk/sort-sdk/src/main/java/org/apache/inlong/sdk/sort/api/ConsumerSubsetType.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.sdk.sort.api; + +/** + * ConsumerSubsetType + */ +public enum ConsumerSubsetType { + + CLUSTER("cluster"), TOPIC("topic"), ALL("all"); + + private final String value; + + private ConsumerSubsetType(String value) { + this.value = value; + } + + public String value() { Review Comment: 1. This value field seems is a lower case of Enum instance, did it needed? 2. If needed, suggest changing to `description`, because the `values` is a inner-method for Enum, it will bring some ambiguity. ########## inlong-sdk/sort-sdk/src/main/java/org/apache/inlong/sdk/sort/api/ConsumerSubsetType.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.sdk.sort.api; + +/** + * ConsumerSubsetType + */ +public enum ConsumerSubsetType { + + CLUSTER("cluster"), TOPIC("topic"), ALL("all"); + + private final String value; + + private ConsumerSubsetType(String value) { + this.value = value; + } + + public String value() { + return this.value; + } + + public String toString() { Review Comment: Suggest adding `@Override` for `toString` method. BTW, maybe the `value()` method can be replaced by `toString` if you change the logic for `toString` like this: ``` @Override public String toString() { return this.name().toLowerCase(Locale.ROOT); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
