healchow commented on code in PR #6954:
URL: https://github.com/apache/inlong/pull/6954#discussion_r1051878634
##########
inlong-sdk/sort-sdk/src/main/java/org/apache/inlong/sdk/sort/api/ClientContext.java:
##########
@@ -17,19 +17,27 @@
package org.apache.inlong.sdk.sort.api;
+import org.apache.inlong.common.metric.MetricRegister;
import org.apache.inlong.sdk.sort.entity.InLongTopic;
-import org.apache.inlong.sdk.sort.stat.SortClientStateCounter;
-import org.apache.inlong.sdk.sort.stat.StatManager;
+import org.apache.inlong.sdk.sort.metrics.SortSdkMetricItem;
+import org.apache.inlong.sdk.sort.metrics.SortSdkMetricItemSet;
+
+import java.util.HashMap;
+import java.util.Map;
public abstract class ClientContext implements Cleanable {
protected final SortClientConfig config;
- protected final StatManager statManager;
+ protected final String sortTaskId;
+
+ protected final SortSdkMetricItemSet metricItemSet;
- public ClientContext(SortClientConfig config, MetricReporter reporter) {
+ public ClientContext(SortClientConfig config) {
this.config = config;
- this.statManager = new StatManager(this, reporter);
+ this.sortTaskId = config.getSortTaskId();
Review Comment:
This PR has too many changes. Is it necessary to add some UTs to verify them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
