[GitHub] [inlong] kuansix commented on a diff in pull request #6825: [INLONG-6822][Sort] Add multi table source for MongoDb

[GitBox]

kuansix commented on code in PR #6825:
URL: https://github.com/apache/inlong/pull/6825#discussion_r1048149015


##########
inlong-sort/sort-connectors/mongodb-cdc/src/main/java/org/apache/inlong/sort/cdc/mongodb/DebeziumSourceFunction.java:
##########
@@ -493,15 +492,6 @@ public void deserialize(SourceRecord record, Collector<T> 
out) throws Exception
                                 deserializer.deserialize(record, out);
                             }
 
-                            @Override
-                            public void deserialize(SourceRecord record, 
Collector<T> out,
-                                    TableChanges.TableChange tableSchema) 
throws Exception {
-                                if (sourceMetricData != null) {
-                                    
sourceMetricData.outputMetricsWithEstimate(record.value());
-                                }
-                                deserializer.deserialize(record, out, 
tableSchema);
-                            }
-

Review Comment:
   > why remove it
   
   mongo has no schema



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org