leezng commented on code in PR #6873:
URL: https://github.com/apache/inlong/pull/6873#discussion_r1047942090


##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -157,6 +164,10 @@
   "meta.Sinks.ES.FlushRecordUnit": "条",
   "meta.Sinks.ES.RetryTimes": "重试次数",
   "meta.Sinks.ES.RetryTimesUnit": "次",
+  "meta.Sinks.ES.EsVersion": "Elasticsearch 版本",

Review Comment:
   Is the irrelevant code here because there is no rebase? You need to remove 
this part of the code.



##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -92,6 +92,13 @@
   "meta.Sources.MQTT.Username": "用户",
   "meta.Sources.MQTT.Password": "密码",
   "meta.Sources.MQTT.MqttVersion": "MQTT 版本",
+  "meta.Sources.Hudi.DbName": "库名",
+  "meta.Sources.Hudi.TableName": "表名",
+  "meta.Sources.Hudi.Warehouse": "仓库路径",
+  "meta.Sources.Hudi.ReadStreamingSkipCompaction": "跳过合并中的提交",
+  "meta.Sources.Hudi.ReadStartCommit": "起始的Commit",
+  "meta.Sources.ReadStreamingSkipCompactionHelp": "流读时是否跳过 compaction 的 
commits,跳过 compaction 有两个用途:1)避免 upsert 语义 下重复消费(compaction 的 instant 
为重复数据,如果不跳过,有小概率会重复消费); 2) changelog 模式下保证语义正确性。 0.11 开始,以上两个问题已经通过保留 
compaction 的 instant time 修复",

Review Comment:
   The prefix here needs to be added with `Hudi`, for example 
"meta.Sources.Hudi.Xxxxx".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to