vernedeng commented on code in PR #6828:
URL: https://github.com/apache/inlong/pull/6828#discussion_r1045455789
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/SortClusterServiceImpl.java:
##########
@@ -249,17 +250,29 @@ private SortClusterConfig getConfigByClusterNameV2(
private List<Map<String, String>> parseIdParamsV2(List<StreamSinkEntity>
streams) {
return streams.stream()
.map(streamSink -> {
- StreamSinkOperator operator =
sinkOperatorFactory.getInstance(streamSink.getSinkType());
- List<String> fields =
fieldMap.get(streamSink.getInlongGroupId());
- return operator.parse2IdParams(streamSink, fields);
+ try {
+ StreamSinkOperator operator =
sinkOperatorFactory.getInstance(streamSink.getSinkType());
+ List<String> fields =
fieldMap.get(streamSink.getInlongGroupId());
+ return operator.parse2IdParams(streamSink, fields);
+ } catch (Exception e) {
+ LOGGER.error("fail to parse id params of groupId={},
streamId={} name={}, type={}}",
+ streamSink.getInlongGroupId(),
streamSink.getInlongStreamId(),
+ streamSink.getSinkName(),
streamSink.getSinkType(), e);
+ return new HashMap<String, String>();
Review Comment:
Fixed, should print logs and filter out all dirty records when parsing them,
instead of return empty objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
