healchow commented on code in PR #6677:
URL: https://github.com/apache/inlong/pull/6677#discussion_r1043245195
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java:
##########
@@ -415,6 +417,28 @@ public void saveOrUpdateExt(String groupId,
List<InlongGroupExtInfo> exts) {
LOGGER.info("success to save or update inlong group ext for
groupId={}", groupId);
}
+ @Override
+ public List<InlongGroupTopicInfo> listTopics(InlongGroupTopicRequest
request) {
+ LOGGER.info("start to list group topic infos, request={}", request);
+ Preconditions.checkNotEmpty(request.getClusterTag(), "cluster tag
should not be empty");
+ List<InlongGroupEntity> groupEntities =
groupMapper.selectByClusterTag(request.getClusterTag());
Review Comment:
This operation has poor performance. It is recommended to filter the query
data directly in SQL according to the request parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
