[GitHub] [inlong] gong commented on a diff in pull request #6799: [INLONG-6797][Sort] Supports dirty data side-output for filesystem sink

[GitBox]

gong commented on code in PR #6799:
URL: https://github.com/apache/inlong/pull/6799#discussion_r1043076118


##########
inlong-sort/sort-connectors/filesystem/src/main/java/org/apache/inlong/sort/filesystem/stream/AbstractStreamingWriter.java:
##########
@@ -141,14 +161,10 @@ protected void commitUpToCheckpoint(long checkpointId) 
throws Exception {
             if (sinkMetricData != null) {
                 sinkMetricData.invoke(rowSize, dataSize);
             }
-        } catch (Exception e) {
-            if (sinkMetricData != null) {
-                sinkMetricData.invokeDirty(rowSize, dataSize);
-            }
-            LOG.error("fileSystem sink commitUpToCheckpoint.", e);
-        } finally {
             rowSize = 0L;
             dataSize = 0L;
+        } catch (Exception e) {
+            LOG.error("fileSystem sink commitUpToCheckpoint.", e);

Review Comment:
   here metric data will not be consistent when commit fail 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org