[GitHub] [inlong] fuweng11 commented on a diff in pull request #6753: [INLONG-6734][Manager] The Raw_CSV data-type marked as not an inlong component

[GitBox]

fuweng11 commented on code in PR #6753:
URL: https://github.com/apache/inlong/pull/6753#discussion_r1040976160


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/pulsar/PulsarSourceOperator.java:
##########
@@ -126,7 +126,12 @@ public Map<String, List<StreamSource>> 
getSourcesMap(InlongGroupInfo groupInfo,
             pulsarSource.setTopic(streamInfo.getMqResource());
             pulsarSource.setAdminUrl(adminUrl);
             pulsarSource.setServiceUrl(serviceUrl);
-            pulsarSource.setInlongComponent(true);
+
+            // CSV: InLong message type whose message body is raw CSV
+            // Raw-CSV: messages are separated by a specific separator
+            // When using RAW_CSV format, not an inlong component
+            boolean isInlongComponent = 
!"RAW_CSV".equals(streamInfo.getDataType());

Review Comment:
   It is recommended to move constants to `InlongConstants`, like 
`InlongConstants.DATA_TYPE_RAW_CSV`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org