healchow commented on code in PR #6524:
URL: https://github.com/apache/inlong/pull/6524#discussion_r1021129804


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java:
##########
@@ -435,7 +435,7 @@ public InlongGroupInfo doDeleteCheck(String groupId, String 
operator) {
 
         // If the status allowed logic delete, all associated info will be 
logically deleted.
         // In other status, you need to delete the related "inlong_stream" 
first.
-        if (!GroupStatus.allowedLogicDelete(curState)) {
+        if (!GroupStatus.notAllowedDelete(curState)) {
             int count = streamService.selectCountByGroupId(groupId);

Review Comment:
   When the inlong group supports the delete operation, we should check whether 
there are undeleted streams.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to