[GitHub] [inlong] EMsnap commented on a diff in pull request #6424: [INLONG-6409][Sort] Unspported Time and Timestamp iceberg auto create table in spark session query

[GitBox]

EMsnap commented on code in PR #6424:
URL: https://github.com/apache/inlong/pull/6424#discussion_r1016189560


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java:
##########
@@ -163,4 +163,11 @@ public final class Constants {
                     .booleanType()
                     .defaultValue(true)
                     .withDescription("Whether ignore the single table erros 
when multiple sink writing scenario.");
+
+    public static final ConfigOption<Boolean> 
SINK_MULTIPLE_TYPE_MAP_COMPATIBLE_WITH_SPARK =
+            ConfigOptions.key("sink.multiple.typemap-compatible-with-spark")
+                    .booleanType()
+                    .defaultValue(false)
+                    .withDescription("Because spark do not support iceberg 
data type: `timestamp without time zone` and"
+                            + "`time`, so type conversions must be mapped to 
types supported by spark.");

Review Comment:
   I guess it's nessasary to mention the conversion explicitly like datetime to 
varchar



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org