healchow commented on code in PR #6358:
URL: https://github.com/apache/inlong/pull/6358#discussion_r1011112092
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/format/CanalJsonDynamicSchemaFormat.java:
##########
@@ -113,6 +113,9 @@ public boolean extractDDLFlag(JsonNode data) {
@Override
public RowType extractSchema(JsonNode data, List<String> pkNames) {
JsonNode schema = data.get(SCHEMA);
+ if (schema == null) {
+ throw new IllegalArgumentException(String.format("Error schema:
%s.", data));
Review Comment:
Personally, I think the 'Error schema' is not accurate enough.
```suggestion
throw new IllegalArgumentException(String.format("Not found
schema from: %s", data));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
