thesumery commented on code in PR #6215: URL: https://github.com/apache/inlong/pull/6215#discussion_r1000720450
########## inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/format/JsonDynamicSchemaFormat.java: ########## @@ -43,8 +66,39 @@ */ public abstract class JsonDynamicSchemaFormat extends AbstractDynamicSchemaFormat<JsonNode> { + private static final Map<Integer, LogicalType> SQL_TYPE_2_ICEBERG_TYPE_MAPPING = Review Comment: Here name is error, it's not business with iceberg. It shoule be called SQL_TYPE_2_FLINK_TYPE_MAPPING -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org