[GitHub] [inlong] Yizhou-Yang commented on a diff in pull request #6202: [INLONG-6054][Manager] Kafka sink supports all migration

[GitBox]

Yizhou-Yang commented on code in PR #6202:
URL: https://github.com/apache/inlong/pull/6202#discussion_r998105336


##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sink/kafka/KafkaSink.java:
##########
@@ -61,6 +61,18 @@ public class KafkaSink extends StreamSink {
     @ApiModelProperty("Primary key is required when serializationType is json, 
avro")
     private String primaryKey;
 
+    @ApiModelProperty("the database-table mapping rule")

Review Comment:
   changed



##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sink/kafka/KafkaSink.java:
##########
@@ -61,6 +61,18 @@ public class KafkaSink extends StreamSink {
     @ApiModelProperty("Primary key is required when serializationType is json, 
avro")
     private String primaryKey;
 
+    @ApiModelProperty("the database-table mapping rule")
+    private String topicPattern;
+
+    @ApiModelProperty(value = "Automatically create kafka topic or not, a note 
for users.")

Review Comment:
   changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org