healchow commented on code in PR #6165:
URL: https://github.com/apache/inlong/pull/6165#discussion_r997683390
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/format/CanalJsonDynamicSchemaFormat.java:
##########
@@ -46,6 +49,18 @@ protected JsonNode getPhysicalData(JsonNode root) {
return null;
}
+ @Override
+ public List<String> extractPrimaryKeyNames(JsonNode data) {
+ JsonNode pkNamesNode = data.get("pkNames");
Review Comment:
Suggest extracting a constant String for `pkNames`.
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/format/DebeziumJsonDynamicSchemaFormat.java:
##########
@@ -46,6 +49,22 @@ protected JsonNode getPhysicalData(JsonNode root) {
return physicalData;
}
+ @Override
+ public List<String> extractPrimaryKeyNames(JsonNode data) {
+ List<String> pkNames = new ArrayList<>();
+ JsonNode sourceNode = data.get("source");
Review Comment:
Suggest extracting a constant String for `source`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
