vernedeng commented on code in PR #6043:
URL: https://github.com/apache/inlong/pull/6043#discussion_r983424962
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/node/DataNodeServiceImpl.java:
##########
@@ -142,6 +142,20 @@ public Boolean delete(Integer id, String operator) {
return false;
}
+ return delete(entity, operator);
+ }
+
+ @Override
+ public Boolean deleteByName(String name, String operator) {
+ DataNodeEntity entity = dataNodeMapper.selectByNameAndType(name, null);
Review Comment:
fixed, thx
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/inner/client/DataNodeClient.java:
##########
@@ -107,4 +107,17 @@ public Boolean delete(Integer id) {
return response.getData();
}
+ /**
+ * Delete data node by name.
+ *
+ * @param name node name to be deleted
+ * @return whether succeed
+ */
+ public Boolean delete(String name) {
Review Comment:
fixed, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
