healchow commented on code in PR #6064: URL: https://github.com/apache/inlong/pull/6064#discussion_r983420274
########## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/sink/iceberg/IcebergResourceOperator.java: ########## @@ -78,11 +87,27 @@ public void createSinkResource(SinkInfo sinkInfo) { this.createTable(sinkInfo); } + private IcebergSinkDTO getIcebergInfo(SinkInfo sinkInfo) { + IcebergSinkDTO icebergInfo = IcebergSinkDTO.getFromJson(sinkInfo.getExtParams()); + + // read uri from data node if not supplied by user + if (StringUtils.isBlank(icebergInfo.getCatalogUri()) + && icebergInfo.getCatalogType().equals(CATALOG_TYPE_HIVE)) { Review Comment: ditto. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org