healchow commented on code in PR #6020:
URL: https://github.com/apache/inlong/pull/6020#discussion_r980979124
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/sink/hive/HiveResourceOperator.java:
##########
@@ -78,6 +84,28 @@ public void createSinkResource(SinkInfo sinkInfo) {
this.createTable(sinkInfo);
}
+ private HiveSinkDTO getHiveInfo(SinkInfo sinkInfo) {
+ HiveSinkDTO hiveInfo = new HiveSinkDTO();
+ String dataNodeName = sinkInfo.getDataNodeName();
+
+ // firstly use data node info if exists
Review Comment:
Suggest using the user-defined params first, if some params were null, then
get them from the data node.
Data nodes are used to store common parameters. We should support users to
customize some parameters and use them preferentially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
