leosanqing commented on code in PR #5843: URL: https://github.com/apache/inlong/pull/5843#discussion_r973816600
########## inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/openapi/MessageQueueController.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.web.controller.openapi; + +import org.apache.inlong.manager.pojo.cluster.queue.MessageQueueClearTopicRequest; +import org.apache.inlong.manager.pojo.cluster.queue.MessageQueueControlRequest; +import org.apache.inlong.manager.pojo.cluster.queue.MessageQueueOfflineRequest; +import org.apache.inlong.manager.pojo.cluster.queue.MessageQueueOnlineRequest; +import org.apache.inlong.manager.pojo.cluster.queue.MessageQueueSynchronizeTopicRequest; +import org.apache.inlong.manager.pojo.common.Response; +import org.apache.inlong.manager.service.cluster.queue.MessageQueueService; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.web.bind.annotation.PostMapping; +import org.springframework.web.bind.annotation.RequestBody; +import org.springframework.web.bind.annotation.RequestMapping; +import org.springframework.web.bind.annotation.RestController; + +import io.swagger.annotations.Api; +import io.swagger.annotations.ApiOperation; + +/** + * Message queue controller + */ +@RestController +@RequestMapping("/openapi") +@Api(tags = "Message-Queue-API") +public class MessageQueueController { + + @Autowired + private MessageQueueService queueService; + + @PostMapping("/cluster/queue/control") + @ApiOperation(value = "Control produce operation and consume operation of Inlong message queue cluster ") + public Response<Void> control(@RequestBody MessageQueueControlRequest request) { Review Comment: Pls add @Validated,if necessary ########## inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/cluster/queue/MessageQueueOnlineRequest.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.pojo.cluster.queue; + +import org.apache.inlong.manager.common.validation.UpdateValidation; + +import javax.validation.constraints.NotBlank; + +import io.swagger.annotations.ApiModel; +import io.swagger.annotations.ApiModelProperty; +import lombok.AllArgsConstructor; +import lombok.Builder; +import lombok.Data; +import lombok.EqualsAndHashCode; +import lombok.NoArgsConstructor; + +/** + * Build relationships between DataProxy cluster and MessageQueue cluster + */ +@Data +@EqualsAndHashCode(callSuper = false) +@Builder +@NoArgsConstructor +@AllArgsConstructor +@ApiModel("Build relationships between DataProxy cluster and MessageQueue cluster") +public class MessageQueueOnlineRequest { + + @NotBlank(groups = UpdateValidation.class, message = "miss message queue cluster name.") Review Comment: If there is only one conditional check, only need this ```suggestion @NotBlank(message = "miss message queue cluster name.") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
