liangyepianzhou commented on code in PR #5879:
URL: https://github.com/apache/inlong/pull/5879#discussion_r972641320
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/LoadNode.java:
##########
@@ -72,7 +73,8 @@
@JsonSubTypes.Type(value = OracleLoadNode.class, name = "oracleLoad"),
@JsonSubTypes.Type(value = GreenplumLoadNode.class, name =
"greenplumLoad"),
@JsonSubTypes.Type(value = DLCIcebergLoadNode.class, name =
"dlcIcebergLoad"),
- @JsonSubTypes.Type(value = DorisLoadNode.class, name = "dorisLoad")
+ @JsonSubTypes.Type(value = DorisLoadNode.class, name = "dorisLoad"),
+ @JsonSubTypes.Type(value = InfluxDBLoadNode.class, name = "influxdb")
Review Comment:
> 2.If it is based on the jdbc connector extension, you can put the
influxdb-jdbc code in the jdbc connector, there is no need to start a single
module
I have a problem with this, this is a jdbc-driver. rather than a jdbc table
API. The JDBC-connector module calls the influx-jdbc-driver module. When the
influx jdbc driver is officially supported, we should delete this module and
replace it with a new jdbc-driver. Writing them together not only makes no
sense but also increases code coupling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
