healchow commented on code in PR #5886:
URL: https://github.com/apache/inlong/pull/5886#discussion_r970247052
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AgentServiceImpl.java:
##########
@@ -211,68 +211,74 @@ private List<DataConfig> fetchFileTasks(TaskRequest
taskRequest) {
}
final String agentIp = taskRequest.getAgentIp();
final String agentClusterName = taskRequest.getClusterName();
- final String uuid = taskRequest.getUuid();
Preconditions.checkTrue(StringUtils.isNotBlank(agentIp) ||
StringUtils.isNotBlank(agentClusterName),
"both agent ip and cluster name are blank when fetching file
task");
List<StreamSourceEntity> sourceEntities =
sourceMapper.selectByAgentIpOrCluster(needAddStatusList,
Lists.newArrayList(SourceType.FILE), agentIp,
agentClusterName);
List<DataConfig> fileTasks = Lists.newArrayList();
for (StreamSourceEntity sourceEntity : sourceEntities) {
- FileSourceDTO fileSourceDTO =
FileSourceDTO.getFromJson(sourceEntity.getExtParams());
Review Comment:
Could you please add unit tests for this class, thanks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
