healchow commented on code in PR #5878:
URL: https://github.com/apache/inlong/pull/5878#discussion_r969413619


##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/DataSeparator.java:
##########
@@ -29,7 +29,8 @@ public enum DataSeparator {
     DASH("-", 45),
     SOH("\001", 1),
     STX("\002", 2),
-    ETX("\003", 3);
+    ETX("\003", 3),

Review Comment:
   We should support custom separators for users, not need to define them in an 
Enum class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to