[GitHub] [inlong] GanfengTan commented on a diff in pull request #5845: [INLONG-5844][Manager] Sub sources should be filtered when querying task status

[GitBox]

GanfengTan commented on code in PR #5845:
URL: https://github.com/apache/inlong/pull/5845#discussion_r966840561


##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/InlongGroupContext.java:
##########
@@ -90,7 +91,10 @@ private List<StreamSource> getGroupSources() {
             if (MapUtils.isNotEmpty(sources)) {
                 for (Map.Entry<String, StreamSource> entry : 
sources.entrySet()) {
                     StreamSource source = entry.getValue();
-                    if (source != null) {
+                    // when template id is null it is considered as normal 
source other than template source
+                    // sub sources are filtered because they are already 
collected in template source's sub source list
+                    System.out.println("get source = " + source);

Review Comment:
   Please, delete the expression.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org