[GitHub] [inlong] thesumery commented on a diff in pull request #5785: [INLONG-5784][Sort] Add metric state for postgreSQL

[GitBox]

thesumery commented on code in PR #5785:
URL: https://github.com/apache/inlong/pull/5785#discussion_r963446399


##########
inlong-sort/sort-connectors/postgres-cdc/src/main/java/org.apache.inlong.sort.cdc.postgres/DebeziumSourceFunction.java:
##########
@@ -273,9 +283,15 @@ public void initializeState(FunctionInitializationContext 
context) throws Except
                         new ListStateDescriptor<>(
                                 HISTORY_RECORDS_STATE_NAME, 
BasicTypeInfo.STRING_TYPE_INFO));
 
+        this.metricState =
+                stateStore.getUnionListState(

Review Comment:
   `getUnionListState` is aggregating all state，here if  before multiple 
subtask have been snapshotted, maybe here can be List<Map<String, Integer>>， 
for every subtask has a different counter value ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org