liangyepianzhou commented on PR #5774:
URL: https://github.com/apache/inlong/pull/5774#issuecomment-1236100125
@jun0315 I have finished writing the main framework of influx source, and
now there are three points that need to be improved. I've listed it below,
please take a look at this question when you have time.
1. Parameters
* The parameters written in the building function in the
`InfluxDBSource` may not be complete. So if you need to add parameters here,
you also need to add them in the `getScanRuntimeProvider` and
`InfluxDBTableSourceFactory`.
* Divide required and optional parameters into the methods
`requiredOptions` and `optionalOptions`
2. Serialization
* InfluxDB Table Source needs to pass in a `deserializer
DebeziumDeserializationSchema<RowData>` deserializer when calling the function;
This can get help at
[flink-connector-influxdb2](https://github.com/apache/bahir-flink/tree/master/flink-connector-influxdb2)
3. Connecter CanonicalName: There is a configuration item in InfluxDBSource
that I don't know how to deal with
` props.setProperty("connector.class",
InfluxDbConnector.class.getCanonicalName());`
In order to better understand the workflow of the Flink influx DB source, I
wrote a simple process described below:
Workflow of Flink source connecter (simplified version):
`InfluxDBTableSourceFactory` creates an `InfluxDBTableSource`, and the
`getScanRuntimeProvider` method of `InfluxDBTableSource` creates a
`DebeziumSourceFunction` responsible for fetching captured change data from the
database into Flink.
And InfluxDBSource is similar to a creator used to create a
DebeziumSourceFunction.
And more details can be found
[here](https://nightlies.apache.org/flink/flink-docs-release-1.14/zh/docs/dev/table/sourcessinks/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
