vernedeng commented on code in PR #5659: URL: https://github.com/apache/inlong/pull/5659#discussion_r953470533
########## inlong-sdk/sort-sdk/src/main/java/org/apache/inlong/sdk/sort/fetcher/pulsar/PulsarMultiTopicsFetcher.java: ########## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.sdk.sort.fetcher.pulsar; + +import com.google.common.base.Preconditions; +import org.apache.commons.collections.CollectionUtils; +import org.apache.commons.lang3.StringUtils; +import org.apache.inlong.sdk.sort.api.ClientContext; +import org.apache.inlong.sdk.sort.api.Deserializer; +import org.apache.inlong.sdk.sort.api.Interceptor; +import org.apache.inlong.sdk.sort.api.MultiTopicsFetcher; +import org.apache.inlong.sdk.sort.api.Seeker; +import org.apache.inlong.sdk.sort.api.SeekerFactory; +import org.apache.inlong.sdk.sort.api.SortClientConfig; +import org.apache.inlong.sdk.sort.entity.InLongMessage; +import org.apache.inlong.sdk.sort.entity.InLongTopic; +import org.apache.inlong.sdk.sort.entity.MessageRecord; +import org.apache.pulsar.client.api.Consumer; +import org.apache.pulsar.client.api.Message; +import org.apache.pulsar.client.api.MessageId; +import org.apache.pulsar.client.api.Messages; +import org.apache.pulsar.client.api.PulsarClient; +import org.apache.pulsar.client.api.PulsarClientException; +import org.apache.pulsar.client.api.Schema; +import org.apache.pulsar.client.api.SubscriptionInitialPosition; +import org.apache.pulsar.client.api.SubscriptionType; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.ArrayList; +import java.util.Base64; +import java.util.Collection; +import java.util.LinkedList; +import java.util.List; +import java.util.Objects; +import java.util.concurrent.TimeUnit; +import java.util.stream.Collectors; + +/** + * MultiTopicsFetcher for pulsar. + * + */ +public class PulsarMultiTopicsFetcher extends MultiTopicsFetcher { + private static final Logger LOGGER = LoggerFactory.getLogger(PulsarMultiTopicsFetcher.class); + private PulsarConsumer currentConsumer; + private List<PulsarConsumer> toBeRemovedConsumers = new LinkedList<>(); + private PulsarClient pulsarClient; + + public PulsarMultiTopicsFetcher( + List<InLongTopic> topics, + ClientContext context, + Interceptor interceptor, + Deserializer deserializer, + PulsarClient pulsarClient) { + super(topics, context, interceptor, deserializer); + this.pulsarClient = Preconditions.checkNotNull(pulsarClient); + } + + @Override + public boolean init() { + Consumer<byte[]> newConsumer = createConsumer(onlineTopics.values()); + if (Objects.isNull(newConsumer)) { + LOGGER.error("create new consumer is null"); + return false; + } + this.currentConsumer = new PulsarConsumer(newConsumer); + InLongTopic firstTopic = onlineTopics.values().stream().findFirst().get(); + this.seeker = SeekerFactory.createPulsarSeeker(newConsumer, firstTopic); + String threadName = String.format("sort_sdk_pulsar_multi_topic_fetch_thread_%d", this.hashCode()); + this.fetchThread = new Thread(new PulsarMultiTopicsFetcher.Fetcher(), threadName); + this.fetchThread.start(); + this.executor.scheduleWithFixedDelay(this::clearRemovedConsumerList, + context.getConfig().getCleanOldConsumerIntervalSec(), + context.getConfig().getCleanOldConsumerIntervalSec(), + TimeUnit.SECONDS); + return true; + } + + private void clearRemovedConsumerList() { + long cur = System.currentTimeMillis(); + List<PulsarConsumer> newList = new LinkedList<>(); + toBeRemovedConsumers.forEach(consumer -> { + long diff = cur - consumer.stopTime; + if (diff > context.getConfig().getCleanOldConsumerIntervalSec() * 1000L || consumer.isEmpty()) { + try { + consumer.close(); + } catch (PulsarClientException e) { + LOGGER.warn("exception in close old consumer {}", e.getMessage(), e); Review Comment: thx, fixed in #5625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
