[GitHub] [inlong] vernedeng commented on a diff in pull request #5630: [INLONG-5628][DataProxy] Add buffer limit of sink dispatch queue

[GitBox]

vernedeng commented on code in PR #5630:
URL: https://github.com/apache/inlong/pull/5630#discussion_r951274166


##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/SinkContext.java:
##########
@@ -37,19 +40,22 @@ public class SinkContext {
     public static final Logger LOG = 
LoggerFactory.getLogger(SinkContext.class);
 
     public static final String KEY_MAX_THREADS = "maxThreads";
-    public static final String KEY_PROCESS_INTERVAL = "processInterval";
-    public static final String KEY_RELOAD_INTERVAL = "reloadInterval";
+    public static final String KEY_PROCESSINTERVAL = "processInterval";
+    public static final String KEY_RELOADINTERVAL = "reloadInterval";
+    public static final String KEY_EVENT_HANDLER = "eventHandler";
+    public static final String KEY_MAX_BUFFERQUEUE_SIZE_KB = 
"maxBufferQueueSizeKb";
+    public static final int DEFAULT_MAX_BUFFERQUEUE_SIZE_KB = 128 * 1024;
 
-    protected final String proxyClusterId;
+    protected final String clusterId;
     protected final String sinkName;
     protected final Context sinkContext;
 
     protected final Channel channel;
-
+    //

Review Comment:
   useless code



##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/SinkContext.java:
##########
@@ -37,19 +40,22 @@ public class SinkContext {
     public static final Logger LOG = 
LoggerFactory.getLogger(SinkContext.class);
 
     public static final String KEY_MAX_THREADS = "maxThreads";
-    public static final String KEY_PROCESS_INTERVAL = "processInterval";
-    public static final String KEY_RELOAD_INTERVAL = "reloadInterval";
+    public static final String KEY_PROCESSINTERVAL = "processInterval";
+    public static final String KEY_RELOADINTERVAL = "reloadInterval";
+    public static final String KEY_EVENT_HANDLER = "eventHandler";
+    public static final String KEY_MAX_BUFFERQUEUE_SIZE_KB = 
"maxBufferQueueSizeKb";
+    public static final int DEFAULT_MAX_BUFFERQUEUE_SIZE_KB = 128 * 1024;
 
-    protected final String proxyClusterId;
+    protected final String clusterId;
     protected final String sinkName;
     protected final Context sinkContext;
 
     protected final Channel channel;
-
+    //
     protected final int maxThreads;
     protected final long processInterval;
     protected final long reloadInterval;
-
+    //

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org