thesumery commented on code in PR #4882:
URL: https://github.com/apache/inlong/pull/4882#discussion_r934097558
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/load/ClickHouseLoadNode.java:
##########
@@ -100,7 +121,7 @@ public String genTableName() {
@Override
public String getPrimaryKey() {
- return super.getPrimaryKey();
+ return primaryKey;
}
@Override
Review Comment:
MayBe this is unnecessary.Clickhouse sink currently is implement by jdbc
connector.But [jdbc table connector
sink](https://nightlies.apache.org/flink/flink-docs-master/api/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSink.html)
don't support applyPartition currently. So get partitionFiled is useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
